[AutoPR azure-mgmt-nginx]-generated-from-SDK Generation - Python-6002138#45661
Open
azure-sdk wants to merge 2 commits intoAzure:mainfrom
Open
[AutoPR azure-mgmt-nginx]-generated-from-SDK Generation - Python-6002138#45661azure-sdk wants to merge 2 commits intoAzure:mainfrom
azure-sdk wants to merge 2 commits intoAzure:mainfrom
Conversation
…, API Version: 2025-11-01, SDK Release Type: stable, and CommitSHA: '6f518a19a4f53c8ccb38b839c6076e3b578d795d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6002138 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…, API Version: 2025-11-01, SDK Release Type: stable, and CommitSHA: '747cf4e0938b84f2790eaabd8760bd97d8998aa1' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6007417 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the azure-mgmt-nginx management SDK package to a newer generated surface (TypeSpec Python code generator) targeting API version 2025-11-01, and bumps the package to a stable 4.0.0 release with updated metadata, samples, and generated tests.
Changes:
- Bump package stability/version metadata (4.0.0, stable classifier/flags) and update changelog.
- Regenerate client/configuration + operations wiring to the newer generator patterns (including
send_request, base URL handling, and new operation groups). - Refresh generated samples/tests to align with the new default API version and signatures.
Reviewed changes
Copilot reviewed 77 out of 81 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/nginx/azure-mgmt-nginx/tsp-location.yaml | Adds TypeSpec source location metadata for regeneration. |
| sdk/nginx/azure-mgmt-nginx/pyproject.toml | Marks package as stable and updates packaging stability flags. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/conftest.py | Updates generator header in test scaffolding. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_waf_policy_operations.py | Removes explicit api_version kwarg and updates generator header. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_waf_policy_operations_async.py | Same as sync: aligns async tests with default API version usage. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_operations.py | Updates operations list test to call list() without explicit api_version. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_operations_async.py | Async variant of operations list test update. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_nginx_deployment_waf_policies_operations.py | Adds new generated tests for nginx_deployment_waf_policies.analysis. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_nginx_deployment_waf_policies_operations_async.py | Async variant of new WAF policy analysis test. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_deployments_operations.py | Updates deployments tests and removes explicit API version passing. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_deployments_operations_async.py | Async deployments test updates. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_default_waf_policy_operations.py | Removes explicit api_version kwarg and updates generator header. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_default_waf_policy_operations_async.py | Async default WAF policy test update. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_configurations_operations.py | Updates configuration tests (signature alignment, default API version usage). |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_configurations_operations_async.py | Async configuration test updates. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_certificates_operations.py | Updates certificate tests and removes explicit api_version. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_certificates_operations_async.py | Async certificate test updates. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_api_keys_operations.py | Updates API key tests and removes explicit api_version. |
| sdk/nginx/azure-mgmt-nginx/generated_tests/test_nginx_management_api_keys_operations_async.py | Async API key test updates. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/waf_policy_list.py | Refreshes generated sample to new generator/header and updated example metadata. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/waf_policy_get.py | Refreshes generated sample to new generator/header and updated example metadata. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/waf_policy_delete.py | Refreshes generated sample to new generator/header and updated example metadata. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/waf_policy_create.py | Refreshes generated sample to new generator/header and updated example metadata. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/operations_list.py | Refreshes generated operations sample and example metadata. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/nginx_deployment_waf_policies_analysis.py | Adds new generated sample for WAF policy analysis operation. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_update.py | Refreshes deployments update sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_update_subnet.py | Refreshes subnet update sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_list.py | Refreshes list sample (subscription placeholder + example metadata). |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_list_by_resource_group.py | Refreshes list-by-RG sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_get.py | Refreshes get sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_get_auto_scale.py | Refreshes autoscale get sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_delete.py | Refreshes delete sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/deployments_create.py | Refreshes create sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/default_waf_policy_list.py | Refreshes default WAF policy list sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/configurations_list.py | Refreshes configurations list sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/configurations_get.py | Refreshes configurations get sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/configurations_delete.py | Refreshes configurations delete sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/configurations_create_or_update.py | Refreshes configurations upsert sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/configurations_analysis.py | Refreshes configurations analysis sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/certificates_list.py | Refreshes certificates list sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/certificates_get.py | Refreshes certificates get sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/certificates_delete.py | Refreshes certificates delete sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/certificates_create_or_update.py | Refreshes certificates upsert sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/api_keys_list.py | Refreshes API keys list sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/api_keys_get.py | Refreshes API keys get sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/api_keys_delete.py | Refreshes API keys delete sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/generated_samples/api_keys_create_or_update.py | Refreshes API keys upsert sample for new generator/default API version. |
| sdk/nginx/azure-mgmt-nginx/CHANGELOG.md | Adds 4.0.0 release notes including new operation groups/models and breaking changes. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/operations/init.py | Updates operations exports/imports to the new generated layout. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/operations/init.py | Async operations exports/imports updated similarly. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/models/_enums.py | Updates enum docs/comments and generator header. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/models/init.py | Switches model exports/imports to new generated model module names. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/_configuration.py | Updates async configuration defaults/docs for 2025-11-01 + new generator header. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/_client.py | Updates async client wiring (operation groups, serializer/deserializer setup, send_request). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/init.py | Updates async package init to import client from new module name. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/_version.py | Bumps SDK version to 4.0.0. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/_validation.py | Adds API-version gating decorator used by newly generated operations. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/_utils/serialization.py | Updates generator header (serialization utilities remain generated). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/_utils/init.py | Updates generator header for utils package init. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/_configuration.py | Updates sync configuration defaults/docs for 2025-11-01. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/_client.py | Updates sync client wiring and exposes send_request. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/init.py | Updates package init to import client from new module name. |
| sdk/nginx/azure-mgmt-nginx/apiview-properties.json | Updates APIView cross-language IDs/definition mappings for the new surface. |
| sdk/nginx/azure-mgmt-nginx/_metadata.json | Updates generation metadata to TypeSpec emitter version + new spec commit and API version. |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/operations/_default_waf_policy_operations.py | Removes legacy per-operation-module generated file (replaced by consolidated operations module). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/operations/_certificates_operations.py | Removes legacy per-operation-module generated file (replaced by consolidated operations module). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/operations/_api_keys_operations.py | Removes legacy per-operation-module generated file (replaced by consolidated operations module). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/operations/_waf_policy_operations.py | Removes legacy async per-operation-module generated file (replaced by consolidated operations module). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/operations/_default_waf_policy_operations.py | Removes legacy async per-operation-module generated file (replaced by consolidated operations module). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/operations/_configurations_operations.py | Removes legacy async per-operation-module generated file (replaced by consolidated operations module). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/operations/_certificates_operations.py | Removes legacy async per-operation-module generated file (replaced by consolidated operations module). |
| sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/operations/_api_keys_operations.py | Removes legacy async per-operation-module generated file (replaced by consolidated operations module). |
Comments suppressed due to low confidence (2)
sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/_client.py:69
- The
NginxManagementClientdocstring listsNoneas a known value forapi_version, but the generated request builders serializeapi-versionviaSerializer.query(...)which raises onNone. Please either removeNonefrom the docstring or update the implementation soapi_version=Noneis actually supported (e.g., omit the query param).
sdk/nginx/azure-mgmt-nginx/azure/mgmt/nginx/aio/_client.py:69 - The
NginxManagementClientdocstring listsNoneas a known value forapi_version, but the generated request builders serializeapi-versionviaSerializer.query(...)which raises onNone. Please either removeNonefrom the docstring or update the implementation soapi_version=Noneis actually supported (e.g., omit the query param).
Comment on lines
+36
to
+37
| :keyword api_version: The API version to use for this operation. Known values are "2025-11-01" | ||
| and None. Default value is "2025-11-01". Note that overriding this default value may result in |
Comment on lines
+36
to
+37
| :keyword api_version: The API version to use for this operation. Known values are "2025-11-01" | ||
| and None. Default value is "2025-11-01". Note that overriding this default value may result in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/nginx/Nginx.Management/tspconfig.yaml', API Version: 2025-11-01, SDK Release Type: stable, and CommitSHA: '6f518a19a4f53c8ccb38b839c6076e3b578d795d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6002138 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=aafe9238-2d1e-f111-8341-000d3a5a7991 Submitted by: briankimutai@microsoft.com
Release Plan Details
Spec pull request: Adding 2025-11-01 spec for Nginx.NginxPlus azure-rest-api-specs#39907
Spec API version: 2025-11-01